Rails 8 compatibility #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `super` there are circumstances (that I haven't understood fully) where you end up with the following error: ``` NoMethodError: super: no superclass method `name=' for an instance of Gutentag::Tag ``` Using `write_attribute` instead seems to help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
superthere are circumstances (that I haven't understood fully) where you end up with the following error:Using
write_attributeinstead seems to help.See https://github.com/ujh/fountainpencompanion/actions/runs/11775441321/job/32795894190 for failing tests and then https://github.com/ujh/fountainpencompanion/actions/runs/11780359201/job/32810787231 for the tests passing with this change.